cute_noker@feddit.dk to Programmer Humor@programming.dev · 17 days agois my PR big enough ?imagemessage-square39linkfedilinkarrow-up1198arrow-down14
arrow-up1194arrow-down1imageis my PR big enough ?cute_noker@feddit.dk to Programmer Humor@programming.dev · 17 days agomessage-square39linkfedilink
minus-squareFMT99@lemmy.worldlinkfedilinkarrow-up5·17 days agoI err on the side of splitting because of what Scratch just said. If I give my colleague 2k lines to review it’ll get slapped with a LGTM and passed. If I send them 100 lines they’ll actually look at it.
minus-squareBoomkop3@reddthat.comlinkfedilinkarrow-up2·17 days agoLooks good to me, are you getting the rocket?
I err on the side of splitting because of what Scratch just said. If I give my colleague 2k lines to review it’ll get slapped with a LGTM and passed. If I send them 100 lines they’ll actually look at it.
LGTM= let’s go to the moon?
Looks good to me, are you getting the rocket?